Skip to content

Commit 8039241

Browse files
pasha-codefreshyaroslav-codefresh
authored andcommitted
Node version for clients (#346)
* not strict node version for clients
1 parent 412202b commit 8039241

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM golang:alpine as go
33
RUN apk add --update ca-certificates git
44
RUN go get github.com/github/hub
55

6-
FROM node:10.15.3-alpine
6+
FROM node:10.13.0-alpine
77

88
RUN apk add --update ca-certificates git curl jq py-pip bash && pip install yq
99
COPY --from=go /go/bin/hub /usr/local/bin/hub

codefresh.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,27 +3,21 @@ version: "1.0"
33

44
steps:
55

6-
prepare_environment_variabels:
7-
title: 'Prepare environment variables'
8-
image: codefresh/cli
9-
commands:
10-
- cf_export RUNTIME_VERSION=$(jq -r ".engines.node" package.json)
11-
126
install_dependencies:
137
title: 'Installing testing dependencies'
14-
image: node:${{RUNTIME_VERSION}}
8+
image: node:10.13.0
159
commands:
1610
- yarn install --frozen-lockfile
1711

1812
eslint:
1913
title: 'Running linting logic'
20-
image: node:${{RUNTIME_VERSION}}
14+
image: node:10.13.0
2115
commands:
2216
- yarn eslint
2317

2418
unit-tests:
2519
title: 'Running unit tests'
26-
image: node:${{RUNTIME_VERSION}}
20+
image: node:10.13.0
2721
commands:
2822
- yarn test
2923

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
"author": "Codefresh",
8989
"license": "ISC",
9090
"engines": {
91-
"node": "10.15.3"
91+
"node": ">=10.13.0"
9292
},
9393
"jest": {
9494
"testEnvironment": "node",

0 commit comments

Comments
 (0)