CR-19527-add-metrics (#364)

* added taskQueue
* expose qps and burst to cli
* added k8s metrics
* updated version to `1.10.0`

* updated to golang `1.21`
* updated mockery to `2.33.``
* updated venona-tester image to `1.21`
* replaced golint with golangci-lint `1.54.2`
* removed unused pipelines (the real ones are coming from `codefresh-io/pipelines` repository under `classic-runtime`)

---------

Co-authored-by: danielm-codefresh <[email protected]>

Author: ATGardner

.gitignore

@@ -42,4 +42,7 @@ venona/venona
 **/*.tgz
 **/charts/**/charts
 **/dry-run.yaml
-**/values-dev.yaml
+**/values-dev.yaml
+
+# coverage
+**/cover

venona/.mockery.boilerplate

@@ -0,0 +1,13 @@
+// Copyright 2023 The Codefresh Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.

venona/.mockery.yaml

@@ -0,0 +1,18 @@
+boilerplate-file: ".mockery.boilerplate"
+dir: "{{.InterfaceDirRelative}}"
+filename: "{{.PackageName}}_mock.go"
+inpackage: true
+with-expecter: true
+packages:
+    github.com/codefresh-io/go/venona/pkg/codefresh:
+        interfaces:
+            Codefresh: {}
+    github.com/codefresh-io/go/venona/pkg/kubernetes:
+        interfaces:
+            Kubernetes: {}
+    github.com/codefresh-io/go/venona/pkg/logger:
+        interfaces:
+            Logger: {}
+    github.com/codefresh-io/go/venona/pkg/metrics:
+        interfaces:
+            Metrics: {}

venona/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.19-alpine3.17 as build
+FROM golang:1.21-alpine3.18 as build
 
 RUN apk -U add --no-cache git make ca-certificates && update-ca-certificates
 
@@ -23,7 +23,7 @@ RUN go mod verify
 # compile
 RUN make build
 
-FROM alpine:3.17
+FROM alpine:3.18
 
 # copy ca-certs and user details
 COPY --from=build /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
@@ -40,4 +40,4 @@ USER venona:venona
 
 ENTRYPOINT [ "venona" ]
 
-CMD [ "start" ]
+CMD [ "start" ]

venona/Makefile

@@ -1,4 +1,14 @@
-.PHONY: build	
+ifndef GOBIN
+ifndef GOPATH
+$(error GOPATH is not set, please make sure you set your GOPATH correctly!)
+endif
+GOBIN=$(GOPATH)/bin
+ifndef GOBIN
+$(error GOBIN is not set, please make sure you set your GOBIN correctly!)
+endif
+endif
+
+.PHONY: build
 build:
 	@sh ./scripts/build.sh
 
@@ -35,8 +45,9 @@ gocyclo:
 	@gocyclo -over 15 .
 
 .PHONY: lint
-lint:
-	@golint -set_exit_status ./...
+lint: $(GOBIN)/golangci-lint
+	@echo linting go code...
+	@$(GOBIN)/golangci-lint run --fix --timeout 10m
 
 .PHONY: security-check
 security-check:
@@ -60,11 +71,18 @@ fmt:
 # Generate mock struct from interface
 # example: make mock PKG=./pkg/runtime NAME=Runtime
 .PHONY: mock
-mock:
-	@sh ./scripts/mock.sh $(PKG) $(NAME)
+mock: $(GOBIN)/mockery
+	@mockery
 
-# Generate mock struct from interface
-# example: make mock PKG=./pkg/runtime NAME=Runtime
+# Runs cript to upload codecov coverage data
 .PHONY: upload-coverage
 upload-coverage:
 	@./scripts/codecov.sh -t $(CODECOV_TOKEN)
+
+$(GOBIN)/mockery:
+	@go install github.com/vektra/mockery/[email protected]
+	@mockery --version
+
+$(GOBIN)/golangci-lint:
+	@echo installing: golangci-lint
+	@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOBIN) v1.54.2

venona/README.md

@@ -1,6 +1,5 @@
 # Venona
 
-
 * venona - the agent process that is running on remote cluster
     * cmd - entrypoints to the application
     * pkg/agent - call Codefresh API every X ms to get new pipelines to run. Also, report status back to Codefresh

venona/VERSION

@@ -1 +1 @@
-1.9.17
+1.10.0

venona/build/Dockerfile.tester

@@ -1,14 +1,12 @@
-FROM golang:1.19-alpine3.17 AS os
+# quay.io/codefresh/venona-tester
+FROM golang:1.21-alpine3.18
 
 RUN apk -U add --no-cache ca-certificates git make gcc g++ bash && update-ca-certificates
-RUN go install github.com/client9/misspell/cmd/misspell@latest && \
-    go install github.com/fzipp/gocyclo/cmd/gocyclo@latest && \
-    go install golang.org/x/lint/golint@latest && \
-    go install github.com/securego/gosec/v2/cmd/gosec@latest && \
-    go install github.com/google/addlicense@latest && \
-    go install github.com/github/hub@latest
+RUN go install github.com/client9/misspell/cmd/[email protected] && \
+    go install github.com/fzipp/gocyclo/cmd/[email protected] && \
+    go install github.com/securego/gosec/v2/cmd/[email protected] && \
+    go install github.com/google/[email protected] && \
+    go install github.com/github/[email protected]+incompatible
 
 RUN apk add curl
 RUN curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/master/contrib/install.sh | sh -s -- -b /usr/local/bin
-
-# quay.io/codefresh/venona-tester