Merge pull request #69 from codefresh-io/vp_upgrade

support upgrade for volume provisioner

Author: oren-codefresh

package.json

@@ -1,6 +1,6 @@
 {
   "name": "venona",
-  "version": "0.28.3",
+  "version": "0.28.4",
   "description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
   "main": "index.js",
   "scripts": {

venonactl/cmd/install.go

@@ -225,10 +225,10 @@ func parseNodeSelector(s string) (nodeSelector, error) {
 
 func validateInstallOptions(opts* plugins.InstallOptions) (error)  {
 	if len(opts.ClusterName) > clusterNameMaxLength {
-		return errors.New(fmt.Sprintf("cluster name lenght is limited to %d", clusterNameMaxLength))
+		return errors.New(fmt.Sprintf("cluster name length is limited to %d", clusterNameMaxLength))
 	}
 	if len(opts.ClusterNamespace) > namespaceMaxLength {
-		return errors.New(fmt.Sprintf("cluster namespace is limited to %d", namespaceMaxLength))
+		return errors.New(fmt.Sprintf("cluster namespace length is limited to %d", namespaceMaxLength))
 	} 	
 	return nil
 }

venonactl/pkg/plugins/volume-provisioner.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 
 	"github.com/codefresh-io/venona/venonactl/pkg/logger"
+	"github.com/codefresh-io/venona/venonactl/pkg/obj/kubeobj"
 	templates "github.com/codefresh-io/venona/venonactl/pkg/templates/kubernetes"
 )
 
@@ -86,6 +87,24 @@ func (u *volumeProvisionerPlugin) Delete(deleteOpt *DeleteOptions, v Values) err
 	return delete(opt)
 }
 
-func (u *volumeProvisionerPlugin) Upgrade(_ *UpgradeOptions, v Values) (Values, error) {
+func (u *volumeProvisionerPlugin) Upgrade(opt *UpgradeOptions, v Values) (Values, error) {
+	var err error
+	kubeClientset, err := opt.KubeBuilder.BuildClient()
+	if err != nil {
+		u.logger.Error(fmt.Sprintf("Cannot create kubernetes clientset: %v ", err))
+		return nil, err
+	}
+	kubeObjects, err := getKubeObjectsFromTempalte(v, volumeProvisionerFilesPattern, u.logger)
+	if err != nil {
+		return nil, err
+	}
+	for _, local := range kubeObjects {
+
+		_, _, err := kubeobj.ReplaceObject(kubeClientset, local, opt.ClusterNamespace)
+		if err != nil {
+			return nil, err
+		}
+	}
 	return v, nil
+
 }

venonactl/pkg/store/store.go

@@ -95,7 +95,7 @@ func (s *Values) BuildValues() map[string]interface{} {
 		},
 		"VolumeProvisionerImage": map[string]string{
 			"Name": "codefresh/dind-volume-provisioner",
-			"Tag":  "v13",
+			"Tag":  "v17",
 		},
 		"Namespace":    s.KubernetesAPI.Namespace,
 		"NodeSelector": s.KubernetesAPI.NodeSelector,