* Revert "pass dockerd params to register call (#41)"

Author: Oleg Sucharevich

package.json

@@ -1,6 +1,6 @@
 {
   "name": "venona",
-  "version": "0.23.0",
+  "version": "0.24.0",
   "description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
   "main": "index.js",
   "scripts": {

venonactl/cmd/install.go

@@ -45,7 +45,6 @@ var installCmdOptions struct {
 	skipRuntimeInstallation       bool
 	runtimeEnvironmentName        string
 	kubernetesRunnerType          bool
-	dockerDaemonParams            string
 }
 
 // installCmd represents the install command
@@ -70,7 +69,6 @@ var installCmd = &cobra.Command{
 			IsDefaultStorageClass: isDefault,
 			DryRun:                installCmdOptions.dryRun,
 			KubernetesRunnerType:  installCmdOptions.kubernetesRunnerType,
-			DockerDaemonParams:    installCmdOptions.dockerDaemonParams,
 		}
 
 		if installCmdOptions.kubernetesRunnerType {
@@ -162,7 +160,6 @@ func init() {
 	installCmd.Flags().StringVar(&installCmdOptions.kube.namespace, "kube-namespace", viper.GetString("kube-namespace"), "Name of the namespace on which venona should be installed [$KUBE_NAMESPACE]")
 	installCmd.Flags().StringVar(&installCmdOptions.kube.context, "kube-context-name", viper.GetString("kube-context"), "Name of the kubernetes context on which venona should be installed (default is current-context) [$KUBE_CONTEXT]")
 	installCmd.Flags().StringVar(&installCmdOptions.storageClass, "storage-class", "", "Set a name of your custom storage class, note: this will not install volume provisioning components")
-	installCmd.Flags().StringVar(&installCmdOptions.dockerDaemonParams, "dockerd-params", "", "Params to be added to each workflow for the docker daemon (https://docs.docker.com/engine/reference/commandline/dockerd/)")
 
 	installCmd.Flags().BoolVar(&installCmdOptions.skipRuntimeInstallation, "skip-runtime-installation", false, "Set flag if you already have a configured runtime-environment, add --runtime-environment flag with name")
 	installCmd.Flags().BoolVar(&installCmdOptions.kube.inCluster, "in-cluster", false, "Set flag if venona is been installed from inside a cluster")

venonactl/go.mod

@@ -3,7 +3,7 @@ module github.com/codefresh-io/venona/venonactl
 require (
 	contrib.go.opencensus.io/exporter/ocagent v0.4.3 // indirect
 	github.com/Azure/go-autorest v11.4.0+incompatible // indirect
-	github.com/codefresh-io/go-sdk v0.14.0
+	github.com/codefresh-io/go-sdk v0.13.0
 	github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect
 	github.com/dustin/go-humanize v1.0.0
 	github.com/go-stack/stack v1.8.0 // indirect

venonactl/go.sum

@@ -16,8 +16,6 @@ github.com/census-instrumentation/opencensus-proto v0.1.0-0.20181214143942-ba49f
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/codefresh-io/go-sdk v0.13.0 h1:puGXvsMISaA3yoFsnf5YSziR8IEHBlATG+KQPvCflrY=
 github.com/codefresh-io/go-sdk v0.13.0/go.mod h1:U8c2f9/Vb2SXFbeKHSzofUOp3N78pDC3YdshFsUfdgc=
-github.com/codefresh-io/go-sdk v0.14.0 h1:pQusBIulCyorNAkmsjalUdjRuzdjrekZW3d4IWrq5sY=
-github.com/codefresh-io/go-sdk v0.14.0/go.mod h1:U8c2f9/Vb2SXFbeKHSzofUOp3N78pDC3YdshFsUfdgc=
 github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE=
 github.com/coreos/go-etcd v2.0.0+incompatible/go.mod h1:Jez6KQU2B/sWsbdaef3ED8NzMklzPG4d5KIOhIy30Tk=
 github.com/coreos/go-semver v0.2.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk=

venonactl/pkg/codefresh/cfapi.go

@@ -42,7 +42,6 @@ type (
 		StorageClass          string
 		IsDefaultStorageClass bool
 		KubernetesRunnerType  bool
-		DockerDaemonParams    string
 	}
 
 	RuntimeEnvironmentRegistrator interface {
@@ -61,7 +60,6 @@ type (
 		storageClass          string
 		isDefaultStorageClass bool
 		kubernetesRunnerType  bool
-		dockerDaemonParams    string
 	}
 
 	logger interface {
@@ -85,7 +83,6 @@ func NewCodefreshAPI(opt *APIOptions) API {
 		storageClass:          opt.StorageClass,
 		isDefaultStorageClass: opt.IsDefaultStorageClass,
 		kubernetesRunnerType:  opt.KubernetesRunnerType,
-		dockerDaemonParams:    opt.DockerDaemonParams,
 	}
 }
 
@@ -164,10 +161,9 @@ func (a *api) Sign() (*certs.ServerCert, error) {
 func (a *api) Register() (*codefresh.RuntimeEnvironment, error) {
 	a.logger.Debug("Registering runtime-environment")
 	options := &codefresh.CreateRuntimeOptions{
-		Namespace:          a.clusternamespace,
-		HasAgent:           a.registerWithAgent,
-		Cluster:            a.clustername,
-		DockerDaemonParams: a.dockerDaemonParams,
+		Namespace: a.clusternamespace,
+		HasAgent:  a.registerWithAgent,
+		Cluster:   a.clustername,
 	}
 	if a.kubernetesRunnerType {
 		options.RunnerType = codefresh.KubernetesRunnerType

venonactl/pkg/plugins/plugin.go

@@ -52,7 +52,6 @@ type (
 		}
 		DryRun               bool
 		KubernetesRunnerType bool
-		DockerDaemonParams   string
 	}
 
 	DeleteOptions struct {

venonactl/pkg/plugins/runtime-environment.go

@@ -52,7 +52,6 @@ func (u *runtimeEnvironmentPlugin) Install(opt *InstallOptions, v Values) (Value
 		StorageClass:          opt.StorageClass,
 		IsDefaultStorageClass: opt.IsDefaultStorageClass,
 		KubernetesRunnerType:  opt.KubernetesRunnerType,
-		DockerDaemonParams:    opt.DockerDaemonParams,
 	}
 
 	cf := codefresh.NewCodefreshAPI(cfOpt)