Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic path with GET request #84

Open
jufemaiz opened this issue Mar 18, 2015 · 4 comments
Open

Dynamic path with GET request #84

jufemaiz opened this issue Mar 18, 2015 · 4 comments

Comments

@jufemaiz
Copy link

Hi all, have a slight conundrum.

Looking at the Hyperclient::Link

https://github.com/codegram/hyperclient/blob/master/lib/hyperclient/link.rb#L84-L91

the _get call on it cannot pass any parameters as params unlike the other options (post, put, and patch)

Where get params are required it cannot be achieved.

@dblock
Copy link
Collaborator

dblock commented Mar 18, 2015

The link itself needs to be templated, then it can be constructed with parameters. You're not supposed to throw in random parameters into a get link as far as I understand. That said I would be open for allowing code to do that I think. Want to try a PR and we can discuss it around code?

@jufemaiz
Copy link
Author

@dblock yep, I get that, however there are times when GET parameters are required - even with a RESTful approach. Will give it a crack. Cheers!

@dblock
Copy link
Collaborator

dblock commented Aug 15, 2015

@bhoggard this is what we discussed for that sort parameter, give it a shot!

dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
@dblock
Copy link
Collaborator

dblock commented Aug 15, 2015

I took a stab at implementing this in #92 and the most efficient solution I found was to patch URITemplate. There're a few questions:

  1. I don't love it this implementation. We're no longer complying with RFC6570 so monkey-patching is not the way to go. But I don't love rewriting the whole class either.
  2. We need to be able to enable/disable this behavior. I wonder whether it needs to be per client, per URI or something else?
  3. Everything needs to be documented.

dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
dblock added a commit that referenced this issue Aug 15, 2015
dblock added a commit to dblock/hyperclient that referenced this issue Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants