-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic path with GET request #84
Comments
The link itself needs to be templated, then it can be constructed with parameters. You're not supposed to throw in random parameters into a get link as far as I understand. That said I would be open for allowing code to do that I think. Want to try a PR and we can discuss it around code? |
@dblock yep, I get that, however there are times when GET parameters are required - even with a RESTful approach. Will give it a crack. Cheers! |
@bhoggard this is what we discussed for that sort parameter, give it a shot! |
I took a stab at implementing this in #92 and the most efficient solution I found was to patch
|
Tests for current behavior, related to #84.
Hi all, have a slight conundrum.
Looking at the Hyperclient::Link
https://github.com/codegram/hyperclient/blob/master/lib/hyperclient/link.rb#L84-L91
the _get call on it cannot pass any parameters as params unlike the other options (post, put, and patch)
Where get params are required it cannot be achieved.
The text was updated successfully, but these errors were encountered: