Skip to content

feat(general-settings): company logo upload #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

vitorjexs
Copy link
Collaborator

  • company logo upload on general settings

image

},
},
);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's missing request the /:id/general-settings/logo here... You need to check if payload has a logo, if so, you can request the API, by doing this you should be able to see the "hello world" from the "Network" tab inside Chrome dev tools (F12).

Take a look at apps/labs/app/_hooks/use-organization.ts line 49 - it's a function like that, but you don't need the function, you can call the API directly here.

After you do that we can refactor to use a Promise.all, but let's do it as a second part, text me when you finish the API call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants