Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SEVERITY a enum? #40

Open
laeubi opened this issue Oct 5, 2022 · 1 comment
Open

Make SEVERITY a enum? #40

laeubi opened this issue Oct 5, 2022 · 1 comment
Labels
breaking enhancement New feature or request

Comments

@laeubi
Copy link
Collaborator

laeubi commented Oct 5, 2022

Currently there are

 /** Constant <code>SEVERITY_WARNING=1</code> */
  int SEVERITY_WARNING = 1;

  /** Constant <code>SEVERITY_ERROR=2</code> */
  int SEVERITY_ERROR = 2;

it might be better to have these (together with INFO and probably DEBUG see #20 )as an Enum to make the code more type safe
@michael-o
Copy link
Member

Yes, this is quite old style...

@slachiewicz slachiewicz added enhancement New feature or request breaking labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michael-o @laeubi @slachiewicz