Inline EmptyScanner into build context #55
Conversation
EmptyScanner is actually only used (and useful) in the DefaultBuildContext and should be a private final inner class to not blow the API that needs to be maintained. Fix codehaus-plexus#46
|
@olamy can you review? |
|
A bit dangerous as consumers could have used |
|
This API is actually used nowhere else as it has a new group ID and m2e was the only provider here and there is no use for the empty scanner there. And exactly for "consumers could have used EmptyScanner (for whatever reason)" I like to get rid of it for the new API (probably even get rid of scanner at all). |
|
Even though the coordinates have changed I would rather keep the API backwards compatible to ease updates. A new API 2.0 should rather be developed in Maven 4…. |
|
Why? m2e will not need any backward compatibility and yes... maven 4... lets talk about that in 2245 maybe... I don't wait that long. An for all that need "backwardcompatible" could simply use the old API, so there is not any value at all, most of the new requirements for such API will not be backward compatible. |
|
Obsolete now |
EmptyScanner is actually only used (and useful) in the DefaultBuildContext and should be a private final inner class to not blow the API that needs to be maintained.
Fix #46