-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WLS file processing will fail in FileAttributes #36
Comments
@forsmpa thanks for reporting. I'll take a look at it. Just to confirm - the change you mentioned as the root cause is not yet released. So I guess you get this error only with master and not with the latest release, right? |
This may also be incomplete support in Java, not our fault. At best someone could come up with an isolated usecase and report it to Rory O'Donnell and/or the nio-dev mailing list. |
I've read the MJAR-273 description. So the root cause seems to be that Java throws exception when a file owner is requested.
|
Rory told me report the issue here. As soon it is publically available, drop him an email with the reference to Maven and he will take care (pass on to others). |
I've reported it. Lets see what happens. But it could also be WSL limitation. In any case -attributes such as ownership may not be available on all file systems. What we should do in such case? I think we support unknown values for file attributes so I think we should return those values instead of throwing exception |
Please provide the internal bug id. I will contact Rory. |
9068518 |
Mailed Rory, let's what happens. |
I finally had time to look at this even more. The second scenario seams to be the case. Some output from the FileAttributes constructor (current HEAD + debug prints) that was my case: In my current findings and case this has an impact on the following plugins.
Yes surrounding Files.readAttributes(path, "owner:*", LinkOption.NOFOLLOW_LINKS) call in constructor with try-catch will "solve" the problem, but the underlying issue seams to be on JDK level. I guess the current ticket will only apply to Oracle JDK so as we are using AdoptOpenJDK 11 HotSpot we need a ticket for them for a fix for this. |
@forsmpa This has already been reported with Oracle. I will try to reach out next week. |
btw I've experimented a bit with WSL2 file system mapped as network drive. Looks like even the |
Windows Linux Subsystem (WLS) mapped network drive files don't provide file ownership data. FileAttributes class constructor fails when attempting to fetch this information.
Looks like the problematic code has been rewritten in #33 .
This has side effect to Maven JAR Plugin (MJAR-273) and Maven WAR Plugin
The text was updated successfully, but these errors were encountered: