LinCombPerRowBias & EVT Changes #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeatodd
force-pushed
the
jtodd/per-row-bias
branch
2 times, most recently
from
4720c36 to
bdcb4bb
Compare
3 tasks
joeatodd
force-pushed
the
jtodd/per-row-bias
branch
from
bdcb4bb to
a704294
Compare
joeatodd
force-pushed
the
jtodd/per-row-bias
branch
from
8d7f032 to
600cbf6
Compare
aacostadiaz
pushed a commit
that referenced
this pull request
Dec 4, 2024
As a precursor to properly testing #152, I have adapted the gemm_testbed_3x.hpp infrastructure slightly for Xe and added a single test case for LinCombEltAct, as that's something we know should work. --------- Co-authored-by: Finlay <[email protected]>
joeatodd
force-pushed
the
jtodd/per-row-bias
branch
from
17df726 to
b5db222
Compare
joeatodd
commented
Dec 5, 2024
aacostadiaz
reviewed
Dec 5, 2024
test/unit/gemm/device/xe_gemm_bf16_bf16_fp32_tensor_op_fp32_evt.cpp
Outdated
Show resolved
Hide resolved
FMarno
reviewed
Dec 5, 2024
test/unit/gemm/device/xe_gemm_bf16_bf16_fp32_tensor_op_fp32_evt.cpp
Outdated
Show resolved
Hide resolved
test/unit/gemm/device/xe_gemm_bf16_bf16_fp32_tensor_op_fp32_evt.cpp
Outdated
Show resolved
Hide resolved
t4c1
reviewed
Dec 5, 2024
test/unit/gemm/device/xe_gemm_bf16_bf16_fp32_tensor_op_fp32_evt.cpp
Outdated
Show resolved
Hide resolved
FMarno
reviewed
Dec 5, 2024
FMarno
reviewed
Jan 7, 2025
tools/util/include/cutlass/util/reference/device/tensor_epilogue.h
Outdated
Show resolved
Hide resolved
tools/util/include/cutlass/util/reference/device/tensor_epilogue.h
Outdated
Show resolved
Hide resolved
tools/util/include/cutlass/util/reference/device/tensor_epilogue.h
Outdated
Show resolved
Hide resolved
tools/util/include/cutlass/util/reference/device/tensor_epilogue.h
Outdated
Show resolved
Hide resolved
tools/util/include/cutlass/util/reference/device/tensor_epilogue.h
Outdated
Show resolved
Hide resolved
tools/util/include/cutlass/util/reference/device/tensor_epilogue.h
Outdated
Show resolved
Hide resolved
t4c1
approved these changes
Jan 9, 2025
joeatodd
force-pushed
the
jtodd/per-row-bias
branch
from
d69570a to
a3d367f
Compare
Not totally sure these are correct yet, but it's compiling...
Co-authored-by: Finlay <[email protected]>
Formatting Co-authored-by: Finlay <[email protected]>
aacostadiaz
approved these changes
Jan 13, 2025
I have rewritten the construction of `rw_coord` in xe_visitor.hpp in terms of subgroup tile shape & coords. This simplifies things & allows to remove the added CtaTileShapeMNK template param.
joeatodd
force-pushed
the
jtodd/per-row-bias
branch
from
a3d367f to
a1df53e
Compare
FMarno
reviewed
Jan 13, 2025
FMarno
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very rough first attempt to get this working. It compiles and runs, but the validation fails.
Testing issues:
Impl issues:
EpilogueTileshape (currently arbitrarily set insideCollectiveEpilogue)Alignmenttemplate arg which is more appropriate for XE