Skip to content

Commit

Permalink
Remove keytar during cross-compile
Browse files Browse the repository at this point in the history
It fails to compile which fails CI.  In the past we were just ignoring
the error.  Since it will be removed shortly and it is already
missing (so not a regression), just skip it entirely.
  • Loading branch information
code-asher committed Sep 22, 2023
1 parent acc50a5 commit 39b7aa9
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ jobs:
- name: Decompress npm package
run: tar -xzf package.tar.gz

# Keytar makes npm install fail. It is going away soon so it might not be
# worth the effort to figure it out.
- name: Remove keytar
run: cd lib/vscode && npm remove keytar

# NOTE@jsjoeio - npm fails here
# so use yarn
- name: Build standalone release
Expand All @@ -161,7 +166,7 @@ jobs:
tar -xf node-${NODE_VERSION}-linux-${NPM_CONFIG_ARCH}.tar.xz node-${NODE_VERSION}-linux-${NPM_CONFIG_ARCH}/bin/node --strip-components=2
mv ./node ./release-standalone/lib/node
# NOTE@jsjoeio - we do this so we can strip out the v
# NOTE@jsjoeio - we do this so we can strip cut the v
# i.e. v4.9.1 -> 4.9.1
- name: Get and set VERSION
run: |
Expand Down

0 comments on commit 39b7aa9

Please sign in to comment.