Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use slug instead of hardcoding coder-jetbrains #458

Open
mingfang opened this issue Aug 4, 2024 · 3 comments
Open

use slug instead of hardcoding coder-jetbrains #458

mingfang opened this issue Aug 4, 2024 · 3 comments

Comments

@mingfang
Copy link

mingfang commented Aug 4, 2024

currently the url uses the harder prefix of coder-jetbrains.

): String = "coder-jetbrains--$workspaceName--${url.safeHost()}"

instead of hardcoding, use the coder_app.slug instead

@code-asher
Copy link
Member

coder_app.slug is on the template, I imagine? I wonder if we can pull this from the API.

But, I wonder if the prefix really matters? It is only used internally.

@mingfang
Copy link
Author

mingfang commented Aug 6, 2024

Normally the prefix does not really matter, but the real problem is the host name part of the URL is limited to 63 characters.
This problem was reported here coder/coder#8145

If a user has a long name, plus if the workspace name is long, then we run into this problem.
Therefore making the prefix shorter helps a little.
For example, my slug for VS Code Web is simply v.
And for JetBrains I was hoping to use jb.

@code-asher
Copy link
Member

That makes sense! Thank you for the additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants