-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed: Close received after close #448
Comments
Can you show your client code? |
@nhooyr go version 1.22.2
|
Unrelated to the library. Something's wrong with your client code calling close after the connection has been closed. See mqttjs/MQTT.js#1361 |
I would reopen this as after last update I have received same error with native WebSocket in Chrome, while safari is ok with that. |
Ok possible we need to add a guard in |
Yes, I saw that it's waiting for closing but CloseNow did not check if it was closed already. I believe that's what's happening. |
That fork includes a fix for the extra close frame problem. See: - coder/websocket#448 - coder/websocket#476
Is #476 the chosen approach here, and if so anything we can do to get it merged? My application is experiencing this same issue. I also noticed another project had decided to fork the library in order to pick up this solution: flowey-org@b1784e6. |
@dgpc yes, that's the chosen approach. The only blocker is that I've been meaning to do some additional testing but haven't gotten around to it. If users like yourself are able to provide feedback whether or not it works as expected/fixes the issue, that would be helpful but not a requirement. I'll try to get it merged this or early next week. |
Hello, I recently encountered a problem. Can someone help me take a look?,
I used the example and successfully ran it, but I sent a ping to the server and received an error below:
The text was updated successfully, but these errors were encountered: