From 0943acfadb8ffc5087e0483deead3acf46202633 Mon Sep 17 00:00:00 2001 From: Rafaela Soares Date: Tue, 10 Dec 2024 12:42:06 +0000 Subject: [PATCH 1/2] update_owners_file --- OWNERS | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/OWNERS b/OWNERS index 9e831d511..bec8eb4aa 100644 --- a/OWNERS +++ b/OWNERS @@ -3,17 +3,21 @@ approvers: - alexeykazakov - MatousJobanek -- sbryzak - xcoulon - rajivnathan - ranakan19 - mfrancisc +- fbm3307 +- metlos +- rsoaresd reviewers: - alexeykazakov - MatousJobanek -- sbryzak - xcoulon - rajivnathan - ranakan19 -- mfrancisc \ No newline at end of file +- mfrancisc +- fbm3307 +- metlos +- rsoaresd \ No newline at end of file From e27d9601ac7a49b0b701ec42dfd30161dad40aa6 Mon Sep 17 00:00:00 2001 From: Rafaela Soares Date: Wed, 11 Dec 2024 09:33:31 +0000 Subject: [PATCH 2/2] remove unnecessary lines --- test/e2e/parallel/spacebindingrequest_test.go | 1 - test/e2e/parallel/vm_webhook_test.go | 1 - testsupport/user_setup.go | 1 - testsupport/wait/awaitility.go | 1 - 4 files changed, 4 deletions(-) diff --git a/test/e2e/parallel/spacebindingrequest_test.go b/test/e2e/parallel/spacebindingrequest_test.go index 35d534777..b818451be 100644 --- a/test/e2e/parallel/spacebindingrequest_test.go +++ b/test/e2e/parallel/spacebindingrequest_test.go @@ -100,7 +100,6 @@ func TestCreateSpaceBindingRequest(t *testing.T) { }) t.Run("error", func(t *testing.T) { - t.Run("unable create space binding request with invalid SpaceRole", func(t *testing.T) { user1 := NewSignupRequest(awaitilities). ManuallyApprove(). diff --git a/test/e2e/parallel/vm_webhook_test.go b/test/e2e/parallel/vm_webhook_test.go index c38498f27..7b21071a8 100644 --- a/test/e2e/parallel/vm_webhook_test.go +++ b/test/e2e/parallel/vm_webhook_test.go @@ -70,7 +70,6 @@ func TestCreateVirtualMachine(t *testing.T) { }, } { t.Run(tcname, func(t *testing.T) { - // create a user for each scenario to avoid vm quota limit username := fmt.Sprintf("test-vm-%d", userCounter) useremail := fmt.Sprintf("%s@redhat.com", username) diff --git a/testsupport/user_setup.go b/testsupport/user_setup.go index 45cfc4450..895797426 100644 --- a/testsupport/user_setup.go +++ b/testsupport/user_setup.go @@ -42,7 +42,6 @@ func createMultipleSignups(t *testing.T, awaitilities wait.Awaitilities, targetC user := signupRequest.Execute(t) signups[i] = user.UserSignup - } return signups } diff --git a/testsupport/wait/awaitility.go b/testsupport/wait/awaitility.go index 6da71d2b4..e9ec45923 100644 --- a/testsupport/wait/awaitility.go +++ b/testsupport/wait/awaitility.go @@ -440,7 +440,6 @@ func (a *Awaitility) WaitForDeploymentToGetReady(t *testing.T, name string, repl t.Logf("waiting until deployment '%s' in namespace '%s' is ready", name, a.Namespace) deployment := &appsv1.Deployment{} err := wait.PollUntilContextTimeout(context.TODO(), a.RetryInterval, 6*a.Timeout, true, func(ctx context.Context) (done bool, err error) { - obj := &appsv1.Deployment{} if err := a.Client.Get(context.TODO(), types.NamespacedName{Namespace: a.Namespace, Name: name}, obj); err != nil { if apierrors.IsNotFound(err) {