Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unclear errors if "flex" not found at configure time (Imported #161) #161

Closed
nmcglo opened this issue Jun 4, 2018 · 1 comment
Closed

unclear errors if "flex" not found at configure time (Imported #161) #161

nmcglo opened this issue Jun 4, 2018 · 1 comment
Assignees
@nmcglo
Labels
enhancement New feature or request
Milestone
CODES 1.2

Comments

@nmcglo
Copy link
Member

nmcglo commented Jun 4, 2018

Original Issue Author: Philip Carns
Original Issue ID: 161
Original Issue URL: https://xgitlab.cels.anl.gov/codes/codes/issues/161

If flex is not found at configure time, configure issues a warning, but then make will attempt to generate .c files using an empty command.

If flex is mandatory, the configure should issue an error rather than a warning.

If flex is optional, then make should not execute rules that require it if it is not present.

See #160
@nmcglo nmcglo self-assigned this Oct 11, 2019
@nmcglo nmcglo added this to the CODES 1.2/2.0 milestone Oct 11, 2019
@nmcglo nmcglo added the enhancement New feature or request label Oct 21, 2019
nmcglo added a commit that referenced this issue Oct 23, 2019
@nmcglo
Fail configure when bison or flex not found
9b50fe4 
Addresses #161. On Mac however there are versions of Bison and Flex
shipped with the OS but don't work (but configure won't catch it).
Installing homebrew and calling `brew install bison flex` will resolve this.
@nmcglo
Copy link
Member Author

nmcglo commented Oct 23, 2019

"resolved". See #191

@nmcglo nmcglo closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmcglo nmcglo

Labels
enhancement New feature or request
Projects
None yet
Milestone
CODES 1.2
Development

No branches or pull requests
1 participant
@nmcglo