Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output buffers in LP states #195

Open
nmcglo opened this issue Nov 11, 2019 · 0 comments
Open

Output buffers in LP states #195

nmcglo opened this issue Nov 11, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request low priority This issue is not actively worked on but isn't a wontfix

Comments

@nmcglo
Copy link
Member

nmcglo commented Nov 11, 2019

Various models use an output buffer which is a static character array of something like 4k chars to output to the LPIO files at the end of the simulation. These are initialized when the LPs are initialized but generally unused until the end. Some models push to them during the sim which I guess is why they're included in the LP state. But is this really necessary or helpful? Wouldn't it be cheaper to handle during the finalize() function of that LP unless otherwise necessary (dragonfly models for instance only use it in finalize()).

Also I have a sneaking suspicion that we're using more than whats allocated in finalize anyway and doing some risky leaky memory stuff.

@nmcglo nmcglo self-assigned this Nov 11, 2019
@nmcglo nmcglo added enhancement New feature or request low priority This issue is not actively worked on but isn't a wontfix labels Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority This issue is not actively worked on but isn't a wontfix
Projects
None yet
Development

No branches or pull requests

1 participant