Better naming

Author: thinkdj

plugin/helpers/helpers.ts

@@ -33,4 +33,4 @@ export function roundToDecimals(value: number | string, decimals: number = 2): n
 }
 
 
-export const notifyConfigDefault = { timeout: 3000, error: false, button: { text: "OK", action: () => console.log("Notification closed") } };
+export const notifyConfigDevDefault = { timeout: 3000, error: false, button: { text: "OK", action: () => console.log("Notification closed") } };

plugin/pluginController.ts

@@ -1,7 +1,7 @@
 /* Config */
 import { PLUGIN_UI_CONFIG as UiConfig } from './config';
 /* Helpers */
-import { getNodeProps, notifyConfigDefault } from './helpers/helpers';
+import { getNodeProps, notifyConfigDevDefault } from './helpers/helpers';
 /* Demo */
 import { createColorfulSpiral } from './demo/spiralGenerator';
 
@@ -20,7 +20,7 @@ figma.ui.onmessage = (msg) => {
         origin: 'figma',
         message: `Created a spiral with ${msg.count} ${msg.shape}s`,
       });
-      figma.notify("Figma: Created spiral", notifyConfigDefault);
+      figma.notify("Figma: Created spiral", notifyConfigDevDefault);
       break;
     case 'demo-insert-quote':
       let quote = msg.quote ?? '';
@@ -38,7 +38,7 @@ figma.ui.onmessage = (msg) => {
           figma.currentPage.appendChild(textNode);
           figma.currentPage.selection = [textNode];
           figma.viewport.scrollAndZoomIntoView([textNode]);
-          figma.notify("Figma: Inserted quote", notifyConfigDefault);
+          figma.notify("Figma: Inserted quote", notifyConfigDevDefault);
         })
         .catch(err => {
           console.error("Failed to load font:", err);
@@ -47,7 +47,12 @@ figma.ui.onmessage = (msg) => {
       break;
     /* /DEMO */
 
-    case 'get-selection-contents-deep':
+    case 'get-frame-contents-deep':
+      /* check if selection has at least one frame */
+      if (!figma.currentPage.selection.some(node => node.type === 'FRAME')) {
+        figma.notify("Figma: No frame selected", notifyConfigDevDefault);  
+        break;
+      }
       const frameContents = figma.currentPage.selection
         .filter(node => node.type === 'FRAME')
         .flatMap(frame => {
@@ -71,15 +76,15 @@ figma.ui.onmessage = (msg) => {
       console.log(frameContents);
       figma.notify("Figma: Selection contents sent. Check console for details.");
       figma.ui.postMessage({
-        type: 'get-selection-contents-deep',
+        type: 'get-frame-contents-deep',
         origin: 'figma',
         message: frameContents,
       });
       break;
 
     case 'show-notification':
       if (msg.message) {
-        figma.notify(msg.message, notifyConfigDefault);
+        figma.notify(msg.message, notifyConfigDevDefault);
       }
       break;
 

ui/app/Demo/SelectionChanges.tsx

@@ -6,9 +6,9 @@ export default function SelectionChanges({ sendToFigma, figmaSelectedNodeCount:
         <div>
             <h3 className="text-md font-bold">Inter-process communication</h3>
             <p className='text-xs text-gray-500 pb-2'>Nodes selected in Figma: {fsnc}</p>
-            <button onClick={() => sendToFigma({ type: 'get-selection-contents-deep' })} type="button"
+            <button onClick={() => sendToFigma({ type: 'get-frame-contents-deep' })} type="button"
             className='text-sm text-white py-1 px-3 rounded-sm bg-blue-500 hover:bg-blue-700'>
-                Get selection contents
+                Get frame contents
             </button>
         </div>
     );