Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reviewers To A Repository #9

Open
LamboCreeper opened this issue Apr 29, 2024 · 0 comments
Open

Add Reviewers To A Repository #9

LamboCreeper opened this issue Apr 29, 2024 · 0 comments
Labels
accepted The issue is accepted and PRs are welcome enhancement New feature or request
Milestone

Comments

@LamboCreeper
Copy link
Member

LamboCreeper commented Apr 29, 2024

Blocked by #8

Description

After a user has imported a repository they need to be able to invite reviewers. This can be achieved by adding the Firebase IDs of the given reviewers to the reviewers array on the relevant repository's database entry.

We currently do not have a way to search for users, as a MVP, simply use IDs from the users collection rather than usernames. This can be revisited later.

This should take place on the repositories/import URL, after Next has been clicked when importing a repository.

Collection: repositories
Document ID: The ID of the given repository
Document Data:

{
    reviewers: String[]; // Add the given IDs to this array.
}

UI Wireframe

image

When a user is added from the search input, display them below. Display an X to remove them. Update the actual database entry's array on click of Import to save on writes.

User Story

As a user
I want to invite people to review my code
So that they can leave feedback for me

Notes

@LamboCreeper LamboCreeper added accepted The issue is accepted and PRs are welcome enhancement New feature or request labels Apr 29, 2024
@LamboCreeper LamboCreeper added this to the MVP milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue is accepted and PRs are welcome enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant