Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to play-dl #1018

Open
phampyk opened this issue Apr 15, 2024 · 1 comment · May be fixed by #1031
Open

Switch to play-dl #1018

phampyk opened this issue Apr 15, 2024 · 1 comment · May be fixed by #1031
Labels
enhancement New feature or request

Comments

@phampyk
Copy link

phampyk commented Apr 15, 2024

I've been trying to play long videos, as I really like compilations of videogame music, or studio ghibli, etc. But when I tried to do that it keeps crashing within seconds, up to a minute, then silence until it exits the VC.

I run muse on Docker, and I did run the DEBUG setting, I do have some logs if you want to look at them. But I was investigating and checking if other bots had same issues and found this eritislami/evobot#1176 which establishes that it's an issue with ytdl-core, and it seems like Muse uses that too, and on the mentioned issue they say that changing to play-dl would fix the issue.

I'm not sure how doable it would be to swap to play-dl, just opening this issue with hopes it could help.
I can send you logs or even links of videos I know give me issues, because every time I try to play them they stop in the exact same spot and refuses to keep playing.

Thank you for the bot, apart from this, it's a great bot!!

@codetheweb
Copy link
Owner

I haven't heard of play-dl before but it looks pretty cool and could replace a lot of libraries that we've historically had issues with. Happy to review a PR switching over if someone wants to take this.

@codetheweb codetheweb added enhancement New feature or request and removed support labels Apr 19, 2024
@codetheweb codetheweb changed the title Issues playing long videos, stop and crashes. Switch to play-dl Apr 19, 2024
@MarcoCoreDuo MarcoCoreDuo linked a pull request May 16, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants