Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsds.nim #36

Open
Bulat-Ziganshin opened this issue Sep 28, 2022 · 0 comments
Open

fsds.nim #36

Bulat-Ziganshin opened this issue Sep 28, 2022 · 0 comments

Comments

@Bulat-Ziganshin
Copy link
Contributor

Bulat-Ziganshin commented Sep 28, 2022

  1. don't use templates when proc will be fine, and especially don't export templates
  2. I suggest using base16 encoding for keys, since Windows doesn't distinguish 'a' from 'A' and prohibits a few plain string filenames like "CON"
  3. path can't contain empty components so ns.field == ns.value == "" should translate into a special value
  4. we may need to deal specifically with empty key (ley.len==0)
  5. it seems that keys "a:b" and "a/b" are both translated into the same filepath. with base16 encoding, we can replace ":" f.e. with "_"
  6. delete shouldn't return failure if file don't exist - according to policy in https://github.com/status-im/nim-codex/wiki/Blockstores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant