Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up open/close in SQLite wrapper #5

Open
michaelsbradleyjr opened this issue Jun 22, 2022 · 0 comments
Open

Tighten up open/close in SQLite wrapper #5

michaelsbradleyjr opened this issue Jun 22, 2022 · 0 comments
Milestone

Comments

@michaelsbradleyjr
Copy link
Contributor

Per discussion in team chat, h/t @Bulat-Ziganshin:

sqlite3_close docs says that it will return non-OK value if some resources weren't closed. It's the great place to check correctness of the code dealing with DB, so don't ignore its return code

sqlite3_open_v2: Whether or not an error occurs when it is opened, resources associated with the database connection handle should be released by passing it to sqlite3_close() when it is no longer required

@Bulat-Ziganshin Bulat-Ziganshin added this to the V2 (safety) milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants