Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add subscription mapping lock #86

Open
emizzle opened this issue Oct 25, 2024 · 0 comments
Open

fix: add subscription mapping lock #86

emizzle opened this issue Oct 25, 2024 · 0 comments

Comments

@emizzle
Copy link
Contributor

emizzle commented Oct 25, 2024

Lock access to the subscriptionMapping table in the subscriptions module. This needs to be done in the getChanges exception handling when a new filter is created (on filter not found), and in the unsubscribe functions, at a minimum.

Create a test scenario where a memory leak would happen such that:

  1. the filter not found error condition is created`
  2. When eth_newFilter is called, and control is given to another function in the event loop (the test), unsubscribe is called which will attempt to delete a filter id that doesn't yet exist (since async control hadn't returned from the eth_newFilter call yet).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant