Added support for lists #11
Conversation
htmlslacker/htmlslacker.py
Outdated
| @@ -55,6 +57,13 @@ def handle_starttag(self, tag, attrs): | |||
| self.output += attr[1] + '|' | |||
| if tag == 'style' or tag == 'script': | |||
| self.skip = True | |||
| if tag == 'ol': | |||
| self.ol_counter_cache = 1 | |||
There was a problem hiding this comment.
It looks like this variable will never be incremented
htmlslacker/htmlslacker.py
Outdated
| self.ol_counter_cache = 1 | ||
| if tag == 'li': | ||
| if self.ol_counter_cache is not None: | ||
| self.output += "%s." % self.ol_counter_cache |
There was a problem hiding this comment.
Please, use .format style:
"{}.".format(self.ol_counter_cache)
| @@ -72,6 +81,8 @@ def handle_endtag(self, tag): | |||
| self.output += '`' | |||
| if tag == 'style' or tag == 'script': | |||
| self.skip = False | |||
| if tag == 'ol': | |||
There was a problem hiding this comment.
based on the other code here, I'm not sure a ul is needed -- i'm not sure what it would do here.
test_general.py
Outdated
|
|
||
| def test_unordered_list(): | ||
| html = '<ul><li>Hello</li></ul>' | ||
| expected = "- Hello" |
There was a problem hiding this comment.
It is necessary to append
output = HTMLSlacker(html).get_output()
assert (output == expected)
Otherwise the test will not work.
test_general.py
Outdated
|
|
||
| def test_ordered_list(): | ||
| html = '<ol><li>one</li><li>two</li></ol>' | ||
| expected = "1. one \n 2. two" |
There was a problem hiding this comment.
Test is not passing
> assert (output == expected)
E AssertionError: assert '1.one1.two' == '1. one \n 2. two'
E - 1.one1.two
E + 1. one
E + 2. two
test_general.py:49: AssertionError
|
@n0str Sorry - i left some unsaved changes in my editor. Updated with your comments, but my only issue is I can't figure out how to get a |
|
Just curious, why was this closed before merging? Currently I have to preprocess the HTML and convert lists to lines starting with a unicode bullet character, which is pretty hacky, so this would be really nice to have. |
Fixes #10