Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use epilog.js subroutine to remove facts that mention a certain object constant #63

Open
pjames27 opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@pjames27
Copy link
Collaborator

I've been made aware of eliminatefacts, an epilog.js subroutine that removes all facts that contain a given symbol.
To reduce redundant code, we should switch to using this subroutine when deleting objects.

When we want more subtle deletion behavior in the future, we will likely still need to write our own deletion subroutine.

@pfw13 pfw13 self-assigned this Apr 24, 2024
pfw13 added a commit that referenced this issue Apr 25, 2024
@pfw13
Copy link
Collaborator

pfw13 commented Apr 25, 2024

I've tried to replace my function with eliminatefacts, but it couldn't get it working. When I call eliminatefacts("claim0", dataset), it'll just clear the whole dataset. I've pushed that code into a new branch instead of main since it isn't working.

@pfw13 pfw13 added the question Further information is requested label Apr 25, 2024
@pjames27 pjames27 self-assigned this Apr 26, 2024
@pjames27
Copy link
Collaborator Author

Hm... I'll give this a shot as well. I was able to get it working on a toy example, but haven't tried it in the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants