Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large gap between name and text on profile page #1480

Open
cellio opened this issue Dec 10, 2024 · 2 comments
Open

Large gap between name and text on profile page #1480

cellio opened this issue Dec 10, 2024 · 2 comments
Assignees
Labels
area: frontend Changes to front-end code complexity: easy Issues that should take limited effort to resolve/fix/build. meta: good first issue Good for newcomers priority: low type: bug Something isn't working

Comments

@cellio
Copy link
Member

cellio commented Dec 10, 2024

After we fixed #1440, I started noticing that the gap on the profile page between the user name and text that follows is larger than I expected:

screenshot

I thought this might be a simple matter of tweaking app/views/users/show.html.erb, but the existing divs and classes are throwing me. I suspect the problem is somewhere in this block:

<div class="grid <%= deleted_user?(@user) ? 'deleted-content' : '' %>">
  <div class="grid--cell is-9-lg is-12">
    <div class="h-p-6 h-p-t-2">
      <div class="profile-text">
      <p>...

The first grid, I think, is setting up the two columns and probably not part of the problem here [1]. I'm not sure whether I should be trying to change the second grid, the divs, the CSS behind one of the six classes involved, or something else.

[1] The profile picture, the top of the right column, is a little higher than the first text below the name in the main part of the page. This makes me think the problem is in or below the second grid.

@cellio cellio added area: frontend Changes to front-end code type: bug Something isn't working priority: low complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Dec 10, 2024
@2S00B5
Copy link

2S00B5 commented Jan 11, 2025

I want to work on this issue

@Oaphi
Copy link
Member

Oaphi commented Jan 11, 2025

Feel free to - just remember to follow the contribution guidelines

@ArtOfCode- ArtOfCode- added meta: good first issue Good for newcomers complexity: easy Issues that should take limited effort to resolve/fix/build. and removed complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Changes to front-end code complexity: easy Issues that should take limited effort to resolve/fix/build. meta: good first issue Good for newcomers priority: low type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants