Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post history for help center and policy posts #1487

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Oaphi
Copy link
Member

@Oaphi Oaphi commented Dec 15, 2024

closes #807

This PR enables post history views for the Help Center and policy posts:

2024-12-15_18-12

2024-12-15_18-11

@Oaphi
Copy link
Member Author

Oaphi commented Dec 15, 2024

Blocked by the system's user community users not being seeded, resulting in /users/-1 link returning 404, as well as in some layout shenanigans (alt text for the missing user's avatar image):

Screenshot from 2024-12-15 19-37-26-1

@Oaphi Oaphi requested review from cellio and a team December 15, 2024 16:40
@Oaphi Oaphi self-assigned this Dec 15, 2024
@Oaphi Oaphi added the status: blocked This is being worked on but is blocked by something else label Dec 15, 2024
@cellio
Copy link
Member

cellio commented Dec 15, 2024

Thanks for working on this! Based on our chat conversation, clicking on the history button will show a post history page like for other posts. (I initially misunderstood this screenshot.) This sounds good to me!

@Oaphi
Copy link
Member Author

Oaphi commented Dec 16, 2024

#1490 should unblock the PR

@@ -464,13 +464,9 @@ def restore
end

def document
@post = Post.unscoped.where(doc_slug: params[:slug], community_id: [RequestContext.community_id, nil]).first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to post.rb -> self.by_slug, no change other than taking parameter

@Oaphi Oaphi marked this pull request as ready for review December 18, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked This is being worked on but is blocked by something else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make edit history available on help posts
2 participants