Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app crashes when I tap on the post MyFeedFragment #2

Open
ankan10 opened this issue Aug 7, 2021 · 2 comments
Open

The app crashes when I tap on the post MyFeedFragment #2

ankan10 opened this issue Aug 7, 2021 · 2 comments

Comments

@ankan10
Copy link

ankan10 commented Aug 7, 2021

Here is the link to the file.
https://github.com/coding-blocks-archives/Conduit_Android_Kotlin/blob/master/app/src/main/java/io/realworld/android/ui/feed/MyFeedFragment.kt

A small issue in line:45 of the MyFeedFragment.kt file is using the global feed fragment as an action when the item is tapped else the app will crash as soon as the item is tapped in My Feed.
Ideally it should be R.id.action_myFeed_openArticle

Please let me correct this even it's small and help me to begin the opensource journey with this issue. Thank You
@championswimmer

@Haid-Faiz
Copy link

Haid-Faiz commented Aug 8, 2021

@ankan10 You can try contributing on this. I have developed it even in a better way... https://github.com/Haid-Faiz/Conduit
Don't forget to star it... if you found this repo helpful.

@ankan10
Copy link
Author

ankan10 commented Aug 8, 2021

@Haid-Faiz Actually I also did it and am on my way to improve more things on it :)
I will check yours out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants