-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Settings button on the home screen isn't functioning. #68
Comments
I was able to reproduce this on my device and will see if I can't fix it and submit a PR. I've never worked on this project before but I'd like to help. |
I've figured out the cause of the bug, there's no SettingsActivity or Fragment 😅 I'll submit a PR to remove the Settings button until the Activity has been created. |
I see it's not going to actually be that easy... I've removed the Settings option but it screws with how they have the Toolbar formatted. Gonna take me a bit more time to fix it seems. |
There we go @vinayakkgarg, I've submitted a PR which fixes the issue. Here's to hoping the maintainers can add it soon. 😄 |
Fixes the issue brought up in #68
Hey @championswimmer, this issue can be closed. I'd close it myself but I don't have permissions too. |
The text was updated successfully, but these errors were encountered: