Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dockerfile #18

Open
jatinkatyal13 opened this issue May 21, 2020 · 4 comments
Open

Fix: Dockerfile #18

jatinkatyal13 opened this issue May 21, 2020 · 4 comments
Labels

Comments

@jatinkatyal13
Copy link
Contributor

Currently while building the docker image, every time we make a change to the source code it reinstalls all the node dependencies again.

You might find this article helpful while working on it.

@HeroicHitesh
Copy link
Contributor

@jatinkatyal13 interested in this issue please assign this to me

@jatinkatyal13
Copy link
Contributor Author

@HeroicHitesh Sure! Go ahead

@HeroicHitesh
Copy link
Contributor

@jatinkatyal13 according to this we need to make a .dockerignore file to exclude node_modules I guess that should resolve this issue. Should I make this file and send a PR?

@HeroicHitesh
Copy link
Contributor

@jatinkatyal13 have a look at PR #21 It might resolve this issue. And we can add .dockerignore as part of good practices of maintaining a Docker project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants