Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tooltip on alpha editor #1129

Closed
John-Paul-Larkin opened this issue Oct 15, 2024 · 8 comments
Closed

Modify tooltip on alpha editor #1129

John-Paul-Larkin opened this issue Oct 15, 2024 · 8 comments

Comments

@John-Paul-Larkin
Copy link
Member

Context

As part of "Meta issue : Editor #1022
We want to modify the tooltip in a few ways.

  • Remove strike through icon
  • Add a suitable icon for link instead of the current text "Link"
  • Add a Horizontal rule, with appropriate icon
  • Add Quotes, with appropriate icon
  • Text dropdown should be removed and replaced with two icons, one for regular text, and one for heading

Screenshots

Tootltip

Additional info

The alpha editor can be found at :

app>(app)>alpha>new

Any questions feel free to ask.

@RockGod1997
Copy link

Hi @John-Paul-Larkin, if this issue is still available, I would like to take it up. Just let me know if you want me to follow any specific order for displaying icons.

@John-Paul-Larkin
Copy link
Member Author

Awesome @RockGod1997
Thanks

@dineshsutihar
Copy link
Contributor

Hi @John-Paul-Larkin , is anyone working on this issue? If not, I would like to work on it.

@RockGod1997
Copy link

Hi @John-Paul-Larkin, I'm sorry I have gotten occupied with other commitments. I don't mind if @dineshsutihar takes the issue up if he is still interested.

@John-Paul-Larkin
Copy link
Member Author

HI @dineshsutihar
@RockGod1997 is working on this I believe.

@John-Paul-Larkin
Copy link
Member Author

@dineshsutihar
Its all yours 🥳

Copy link

Uh oh! @dineshsutihar, the image you shared is missing helpful alt text. Check #1129 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@dineshsutihar
Copy link
Contributor

@John-Paul-Larkin @NiallJoeMaher I've created a PR. Could you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants