Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a light/dark/system theme switcher #437

Closed
Tracked by #63
NiallJoeMaher opened this issue Sep 28, 2023 · 5 comments
Closed
Tracked by #63

Add a light/dark/system theme switcher #437

NiallJoeMaher opened this issue Sep 28, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@NiallJoeMaher
Copy link
Contributor

Context

Currently we have no way to toggle light and dark themes other than relying on system settings.
We should give the user an option to toggle light/dark/system modes.

Expected Behavior

The user can easily change themes.
We should use next-themes: https://www.npmjs.com/package/next-themes

Help with ideas please

I'm unsure where the best place is to locate this button/dropdown so happy to take some ideas before tackling.

@Prasanthisandaka2005
Copy link

Hello @NiallJoeMaher

Myself Prasanthi Sandaka
Implementing a theme toggle is a great idea for enhancing the user experience on your platform. Here are a few ideas on where we could place this button/dropdown:

Screenshot (51)

I'm excited to take on the task of implementing the theme toggle feature. It's a valuable addition to your platform that will enhance the user experience. I'm eager to learn and make a positive impact. Can you please assign this to me?

@NiallJoeMaher
Copy link
Contributor Author

Hey @Prasanthisandaka2005! I was thinking of something a little more subtle. If we can I like to use hero icons (since it's already installed) like in here: https://syntax.tailwindui.com/

With the default state of the system, we can have the light/dark modes.

Maybe even putting this in the footer will suffice for now, and we can figure out some better, more evident placing when it's working.

Let me know what you think. 🦾

@DarrachBarneveld
Copy link
Contributor

Added a basic demo
giphy

@NiallJoeMaher
Copy link
Contributor Author

@DarrachBarneveld nice! Open up a PR. This will do nicely for now. 🦾 If you need help, let me know.

@NiallJoeMaher
Copy link
Contributor Author

Closed with #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants