Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Bubble menu H1 formatting #504

Closed
xiaoniuniu89 opened this issue Oct 8, 2023 · 5 comments
Closed

Editor: Bubble menu H1 formatting #504

xiaoniuniu89 opened this issue Oct 8, 2023 · 5 comments

Comments

@xiaoniuniu89
Copy link
Contributor

Context

sub story of #197

Expected Behavior

user should not be able to add any extra H1 tags to their post other than the title

Current Behavior

the bubble menu still has an H1 formatting option

Screenshots

Screenshot 2023-10-08 at 21 44 03

Steps to reproduce

Please provide detailed steps for reproducing the issue

go to alpha/create/new
write some text
highlight it and select H1

Additional info

check out the BubbleMenu.tsx and remove H1 as a formatting option

@NiallJoeMaher
Copy link
Contributor

My thoughts on this is to have the h1 become h2 behind the scenes, and so on.

Just as a user experience it might be weird to have the missing h1 when we can just label it h1 and show a h2.

@xiaoniuniu89
Copy link
Contributor Author

replace with A large/small text icon from your original figma. That would be easy fix also

@xiaoniuniu89
Copy link
Contributor Author

think that is the same in medium also

@xiaoniuniu89
Copy link
Contributor Author

changing behaviour of H1 to h2 and h2 to h3 is very easy to do - I leave it to whoever picks this up ;)

@NiallJoeMaher
Copy link
Contributor

This was closed recently, we only have level 2/3 options "Heading" and "Subheading".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants