Niu/prompt dialog #669
Merged
Niu/prompt dialog #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoniuniu89
requested review from
pkspyder007 and
NiallJoeMaher
as code owners
|
@xiaoniuniu89 is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
xiaoniuniu89
force-pushed
the
niu/promptDialog
branch
from
ea4b157
to
7ea8e3a
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ercept route changes, update prompt for unsaved changes
xiaoniuniu89
force-pushed
the
niu/promptDialog
branch
from
03860a2
to
3ffb43e
Compare
|
Build error! I'll take a look in the morning and see if it's something obvious. |
|
sure, can send me results from build log and I can have a look during the week, |
|
Had some unresolved changes i didnt fix in alpha editor, should pass now. |
|
@NiallJoeMaher I have passing build locally now - lint was failing, we can update pre commit hook for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Codu Pull Request 💻
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
Pull Request details:
This pr updates prompt dialog for unsaved changes to work with next 14 and the app router. It also includes some updated abstractions to make it more reusable eg: delete article.
Any Breaking changes:
none - not implemented in alpha/new editor
Associated Screenshots:
( Welcome file extensions include gifs/png screenshots of your feature in action )