Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PopularTags to Use useEffect and useState for Data Fetching #796

Open
coderabbitai bot opened this issue Mar 3, 2024 · 2 comments
Open

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2024

In the context of PR #795, it was suggested to refactor the component to use and for data fetching and state management, aligning with React's best practices. This follows the pattern established in but is considered a good candidate for enhancement.

The current implementation uses an asynchronous function directly within the component, which is not typical for React components that perform data fetching. Refactoring this to use the React hooks for fetching data and for managing the tags state is suggested to improve code consistency and adherence to best practices.

This issue serves as a placeholder for someone to pick up and work on this enhancement, ensuring the component is optimized for maintainability and readability.

Related PR: #795
Related comment: #795 (comment)

Copy link

github-actions bot commented Mar 3, 2024

Hello @coderabbitai[bot], thanks for opening your first issue! your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible.

@JohnAllenTech
Copy link
Contributor

This may not make sense if the PR doesnt get approved but I followed the established pattern thats found in server/libs.posts.ts.

Therefore posts.ts also has this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant