Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling #4

Open
cofonseca opened this issue Mar 18, 2017 · 5 comments
Open

Improve Error Handling #4

cofonseca opened this issue Mar 18, 2017 · 5 comments

Comments

@cofonseca
Copy link
Owner

cofonseca commented Mar 18, 2017

Investigate ways to improve error handling. Not much error handling is being done right now.

Open to ideas on the best way to do this.

@cofonseca cofonseca changed the title Implement Try/Catch For Better Error Handling Improve Error Handling Jul 16, 2017
@mdavis332
Copy link
Contributor

#12 Created PR as one example (for Invoke-WebRequest). Let me know if you had thoughts on handling other errors instead.

@cofonseca
Copy link
Owner Author

Thanks @mdavis332! The only scenarios I can think of handling so far are some of the more obvious ones:

  • API is down, or there's some sort of network connectivity issue
  • Invalid API key
  • Invalid request body (Add-HipChatUserToRoom for a user or room that doesn't actually exist, for example)
  • Generic errors

I merged your basic try/catch for now. We can expand on it from there.

@midacts
Copy link

midacts commented Oct 9, 2017

HipChat Access Request

Is there a way you guys can grant me "pleb" access to your hipchat team?
I don't have any access (so I don't have a way to test).

Builds/Appveyor

Also, since I don't own the repo I can't do this, but if the owner has or would like to setup an appveyor account, i will commit the code for a working build and work with you to get it running (maybe through discord, etc).

@cofonseca
Copy link
Owner Author

Hey @midacts ,

We don't have an actual HipChat account/team set up for this. The API key used in the tests and in the comment-based help is an example key only, so anyone planning on using this in production (or to test) would have to have their own HipChat account and API key.

I had this working in AppVeyor at one point, but didn't really have much time to get the build process dialed in, so I decided to scrap the idea. I've though about rebuilding it, however Atlassian has announced that HipChat will be getting deprecated in the near future, so I decided it wasn't worth pursuing further. I've been occasionally uploading the new version to PSGallery in the meantime, and will work on doing so in the near future.

If you'd like to get AppVeyor working anyway for shits and giggles, I'd be happy to work with you on it!

@midacts
Copy link

midacts commented Oct 10, 2017

Depricated

Alas, I did not know it was dying.

Access

dummy keys - gotcha.
I was wondering if you had an account i could use to test the code out with and to work on a few of the posted issues. (idk how i can make PRs without actually testing it).

Builds/Appveyor

What's the best way to work on that with you?
PR, gist, etc?

It is pretty much copy and paste with just a few modifications.
Then you just have appveyor enabled on this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants