-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Error Handling #4
Comments
#12 Created PR as one example (for Invoke-WebRequest). Let me know if you had thoughts on handling other errors instead. |
Thanks @mdavis332! The only scenarios I can think of handling so far are some of the more obvious ones:
I merged your basic try/catch for now. We can expand on it from there. |
HipChat Access RequestIs there a way you guys can grant me Builds/AppveyorAlso, since I don't own the repo I can't do this, but if the owner has or would like to setup an |
Hey @midacts , We don't have an actual HipChat account/team set up for this. The API key used in the tests and in the comment-based help is an example key only, so anyone planning on using this in production (or to test) would have to have their own HipChat account and API key. I had this working in AppVeyor at one point, but didn't really have much time to get the build process dialed in, so I decided to scrap the idea. I've though about rebuilding it, however Atlassian has announced that HipChat will be getting deprecated in the near future, so I decided it wasn't worth pursuing further. I've been occasionally uploading the new version to PSGallery in the meantime, and will work on doing so in the near future. If you'd like to get AppVeyor working anyway for shits and giggles, I'd be happy to work with you on it! |
DepricatedAlas, I did not know it was dying. Accessdummy keys - gotcha. Builds/AppveyorWhat's the best way to work on that with you? It is pretty much copy and paste with just a few modifications. |
Investigate ways to improve error handling. Not much error handling is being done right now.
Open to ideas on the best way to do this.
The text was updated successfully, but these errors were encountered: