Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sci-kit learn neural networks #5

Open
jalving opened this issue Oct 19, 2021 · 5 comments
Open

Support for sci-kit learn neural networks #5

jalving opened this issue Oct 19, 2021 · 5 comments

Comments

@jalving
Copy link
Collaborator

jalving commented Oct 19, 2021

Is there interest in adding other readers in addition to ONNX? I have a working sci-kit learn neural network reader.

@fracek
Copy link
Member

fracek commented Oct 20, 2021

At the moment with ONNX we can support keras, tensorflow, and pytorch. Scikit has an ONNX exporter but I'm not sure how it works with neural networks.

@joshuahaddad
Copy link
Collaborator

joshuahaddad commented Feb 8, 2022

@jalving do you still have interest in this? I saw there’s a package sklearn2onnx so I could work on building this out. Alternatively since the package exists we could just have the user do the conversion?

@jalving
Copy link
Collaborator Author

jalving commented Feb 9, 2022

I think we should at least test out the converter and make sure that onnx model imports into OMLT. I think we should also add links to the ONNX converters for various ML platforms. Once we do that, we should discuss a direct interface to sci-kt learn. It's another interface to support, but it might be worthwhile.

@joshuahaddad
Copy link
Collaborator

I was curious so I messed around a bit with it today in between classes. I also wrote some code to convert sklearn scalers into OMLT scaling objects. It’s on my fork here https://github.com/joshuahaddad/OMLT/blob/sklearn-reader/src/omlt/io/sklearn-reader.py.

We should definitely talk about the specifics of the interface. I’d be interested in seeing some of the sklearn models Carl had if they’re not proprietary.

@jalving
Copy link
Collaborator Author

jalving commented Feb 10, 2022

This is pretty cool. Going through ONNX is a good way to support sklearn models. I have a sklearn model that is not proprietary. I will send it your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants