Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Bucket is Hard Coded #2

Open
brockoffdev opened this issue Jun 1, 2017 · 1 comment
Open

S3 Bucket is Hard Coded #2

brockoffdev opened this issue Jun 1, 2017 · 1 comment

Comments

@brockoffdev
Copy link

Hi :)

I'm going to try and open a PR for this, but right now the S3 bucket is hard coded to what appears to be an operable dev bucket? Our team would love to use this bundle, but it's a no go so long as that remains. We should be able to easily add vars to the config for AWS Access and Secret keys correct?

Thanks!

@davejlong
Copy link
Member

Hey @brockoffdev,
This bug looks like it would be pretty easy to fix if you want to give it a shot. To extend this a little bit, you'll also want the region to be configurable as well, so here's the changes to make:

  1. Add configuration options to config.yml for GRAFANA_BUCKET and GRAFANA_REGION
  2. Change the code in lib/grafana/client.rb to use the environment variables instead of the hard coded values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants