Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueErrors too generic too do a proper error handling #853

Open
peetcremer1 opened this issue Sep 14, 2021 · 0 comments
Open

ValueErrors too generic too do a proper error handling #853

peetcremer1 opened this issue Sep 14, 2021 · 0 comments

Comments

@peetcremer1
Copy link
Contributor

cognite-sdk-python/cognite/client/_api_client.py

Line 688 in 3048fe0

raise ValueError("No ids specified")

There are a lot of ValueErrors raised in this file (and I suppose also other locations in the cognite api client)
These errors are too generic to do a proper error handling with. If the cognite api client is used in any other part of the API, it is unclear whether these ValueErrors should be transformed to 400, 403, or 500 errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peetcremer1