-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hacktoberfest: Limit the amount of displayed lines to 20 #255
Comments
Hello Sir, I have gone through the repository and the given instructions. The issue seems to attract my interest and excites me to work on it. I humbly wait for you to assign the task to me if your analysis of my profile allows. Yours Sincerely, |
Thank you and I am excited to have got this issue assigned. Will start PRs once the hacktoberfest starts. Giriraj Roy |
If this is still open, I would like to take this up. |
Thank you for your interest but this is assigned to @Giriraj-Roy , we would let you know in case he can't finish it. |
Hello sir, Thank you, |
@Giriraj-Roy the steps are:
For developing the React FE |
@Giriraj-Roy looks good ! 👍 But weed to do few more things. I left the comments on the MR. |
This issue is free to grab 👍 |
Difficulty: Easy
Getting started steps: https://github.com/cohstats/coh2stats#development
Add button switch to filter only top 20 lines from the array of bulletins.
On the stats page https://coh2stats.com/stats?range=month&statsSource=all&type=4v4&race=wermacht&timeStamp=1661990400
We have card for intel bulletins, to the header of the card, add switch which will display either all or top 20 only.
Implementation
There is component called bulletin card https://github.com/cohstats/coh2stats/blob/master/packages/web/src/pages/stats/components/bulletin-card.tsx
Add there a state, which will be default true - filter only top 20. Add switch https://ant.design/components/switch/ which will change the state, either filter or not. Data are in
bulletinData
, you will need to sort than cut.How to put a switch into header of card can be found here https://github.com/cohstats/coh2stats/blob/master/packages/web/src/components/factions.tsx#L234
Feel free to ask any question. In case you pick the issue, write a comment so you can lock it.
The text was updated successfully, but these errors were encountered: