Skip to content

Commit 5a30797

Browse files
authored
Update CI cluster tag variable name (#718)
1 parent c854024 commit 5a30797

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

tests/benchmarks/test_parquet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515

1616

1717
@pytest.fixture(scope="module")
18-
def parquet_cluster(dask_env_variables, cluster_kwargs, gitlab_cluster_tags):
18+
def parquet_cluster(dask_env_variables, cluster_kwargs, github_cluster_tags):
1919
with Cluster(
2020
f"parquet-{uuid.uuid4().hex[:8]}",
2121
environ=dask_env_variables,
22-
tags=gitlab_cluster_tags,
22+
tags=github_cluster_tags,
2323
**cluster_kwargs["parquet_cluster"],
2424
) as cluster:
2525
yield cluster

tests/benchmarks/test_spill.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717

1818
@pytest.fixture(scope="module")
19-
def spill_cluster(dask_env_variables, cluster_kwargs, gitlab_cluster_tags):
19+
def spill_cluster(dask_env_variables, cluster_kwargs, github_cluster_tags):
2020
with Cluster(
2121
name=f"spill-{uuid.uuid4().hex[:8]}",
2222
environ=merge(
@@ -27,7 +27,7 @@ def spill_cluster(dask_env_variables, cluster_kwargs, gitlab_cluster_tags):
2727
"DASK_DISTRIBUTED__SCHEDULER__ALLOWED_FAILURES": "0",
2828
},
2929
),
30-
tags=gitlab_cluster_tags,
30+
tags=github_cluster_tags,
3131
**cluster_kwargs["spill_cluster"],
3232
) as cluster:
3333
yield cluster

tests/benchmarks/test_work_stealing.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ def test_work_stealing_on_scaling_up(
3232
benchmark_all,
3333
cluster_kwargs,
3434
dask_env_variables,
35-
gitlab_cluster_tags,
35+
github_cluster_tags,
3636
):
3737
with Cluster(
3838
name=test_name_uuid,
3939
environ=dask_env_variables,
40-
tags=gitlab_cluster_tags,
40+
tags=github_cluster_tags,
4141
**cluster_kwargs["test_work_stealing_on_scaling_up"],
4242
) as cluster:
4343
with Client(cluster) as client:
@@ -93,13 +93,13 @@ def test_work_stealing_on_straggling_worker(
9393
benchmark_all,
9494
cluster_kwargs,
9595
dask_env_variables,
96-
gitlab_cluster_tags,
96+
github_cluster_tags,
9797
):
9898
kwargs = cluster_kwargs["test_work_stealing_on_straggling_worker"]
9999
with Cluster(
100100
name=test_name_uuid,
101101
environ=dask_env_variables,
102-
tags=gitlab_cluster_tags,
102+
tags=github_cluster_tags,
103103
**kwargs,
104104
) as cluster:
105105
with Client(cluster) as client:

tests/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ def _benchmark_all(client):
399399

400400

401401
@pytest.fixture(scope="session")
402-
def gitlab_cluster_tags():
402+
def github_cluster_tags():
403403
tag_names = [
404404
"GITHUB_JOB",
405405
"GITHUB_REF",
@@ -457,12 +457,12 @@ def cluster_kwargs():
457457

458458

459459
@pytest.fixture(scope="module")
460-
def small_cluster(request, dask_env_variables, cluster_kwargs, gitlab_cluster_tags):
460+
def small_cluster(request, dask_env_variables, cluster_kwargs, github_cluster_tags):
461461
module = os.path.basename(request.fspath).split(".")[0]
462462
with Cluster(
463463
name=f"{module}-{uuid.uuid4().hex[:8]}",
464464
environ=dask_env_variables,
465-
tags=gitlab_cluster_tags,
465+
tags=github_cluster_tags,
466466
**cluster_kwargs["small_cluster"],
467467
) as cluster:
468468
yield cluster

tests/runtime/test_cluster_creation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
def test_default_cluster_spinup_time(
7-
benchmark_time, gitlab_cluster_tags, get_cluster_info
7+
benchmark_time, github_cluster_tags, get_cluster_info
88
):
99
"""Note: this test must be kept in a separate module from the tests that use the
1010
small_cluster fixture (which has the scope=module) or its child small_client.
@@ -16,7 +16,7 @@ def test_default_cluster_spinup_time(
1616
name=f"test_default_cluster_spinup_time-{uuid.uuid4().hex[:8]}",
1717
n_workers=1,
1818
package_sync=True,
19-
tags=gitlab_cluster_tags,
19+
tags=github_cluster_tags,
2020
) as cluster:
2121
with get_cluster_info(cluster):
2222
pass

tests/stability/test_deadlock.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ def test_repeated_merge_spill(
1717
benchmark_all,
1818
cluster_kwargs,
1919
dask_env_variables,
20-
gitlab_cluster_tags,
20+
github_cluster_tags,
2121
):
2222
with Cluster(
2323
name=f"test_repeated_merge_spill-{uuid.uuid4().hex[:8]}",
2424
environ=dask_env_variables,
25-
tags=gitlab_cluster_tags,
25+
tags=github_cluster_tags,
2626
**cluster_kwargs["test_repeated_merge_spill"],
2727
) as cluster:
2828
with Client(cluster) as client:

0 commit comments

Comments
 (0)