Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPC-H] Switching to scan_parquet from scan_pyarrow_dataset caused Polars test failures #1396

Open
hendrikmakait opened this issue Feb 15, 2024 · 8 comments

Comments

@hendrikmakait
Copy link
Member

hendrikmakait commented Feb 15, 2024

In #1394, we switched to pl.scan_parquet to enable streaming. This has caused some of the TPC-H queries to fail.

FAILED tests/tpch/test_polars.py::test_query_3 - polars.exceptions.ComputeError: cannot sort column of dtype `binary[offset]`
FAILED tests/tpch/test_polars.py::test_query_7 - pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value
FAILED tests/tpch/test_polars.py::test_query_8 - polars.exceptions.InvalidOperationError: `year` operation not supported for dtype `i64`
FAILED tests/tpch/test_polars.py::test_query_9 - polars.exceptions.InvalidOperationError: `year` operation not supported for dtype `i64`
FAILED tests/tpch/test_polars.py::test_query_18 - polars.exceptions.ComputeError: cannot sort column of dtype `binary[offset]`
@hendrikmakait hendrikmakait changed the title [TPC-H] Switching to read_parquet from scan_pyarrow_dataset caused Polars test failures [TPC-H] Switching to scan_parquet from scan_pyarrow_dataset caused Polars test failures Feb 15, 2024
@hendrikmakait
Copy link
Member Author

Note that all of these queries work if I disable streaming.

@ritchie46
Copy link
Contributor

ritchie46 commented Feb 15, 2024

Some of these bugs are due to our string refactor. Which polars version was this?

@hendrikmakait
Copy link
Member Author

This is 0.20.8.

@ritchie46
Copy link
Contributor

Alright. I will take a look.

@hendrikmakait
Copy link
Member Author

Thanks, let me know if I can help you with anything, e.g., by filing more detailed issues.

@ritchie46
Copy link
Contributor

Thanks, I will fix this. I am also on vacation, so give me a few days. :)

@mrocklin
Copy link
Member

Thanks, I will fix this. I am also on vacation, so give me a few days. :)

Your idea of a vacation is different from most people I know 🙂

@ritchie46
Copy link
Contributor

Your idea of a vacation is different from most people I know 🙂

Yes, took a while before my GF accepted that. 😹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants