From 61b4fb606565fbbcee5c5391495a1449b00223d8 Mon Sep 17 00:00:00 2001 From: Giuseppe Macri Date: Thu, 7 Dec 2023 08:48:11 -0500 Subject: [PATCH] updated github action cache value Signed-off-by: Giuseppe Macri --- .github/actions/setup/action.yml | 2 +- src/utils/perfume.test.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index a741ac1..284c564 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -21,7 +21,7 @@ jobs: uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - cache: 'yarn' + cache: 'npm' - name: Install dependencies run: yarn install - name: Format Check diff --git a/src/utils/perfume.test.ts b/src/utils/perfume.test.ts index 69e83d0..49b6509 100644 --- a/src/utils/perfume.test.ts +++ b/src/utils/perfume.test.ts @@ -611,6 +611,7 @@ describe('perfume', () => { test('should call markNTBT() when platform is web', () => { initPerfMonitoring(); // eslint-disable-next-line @typescript-eslint/no-unused-expressions + // TODO: if we don't passe the mock NTBT we can't really test it // perfumeInstance ? (perfumeInstance.markNTBT = mockMarkNTBT) : null; markNTBT(); expect(mockMarkNTBT).toHaveBeenCalled();