Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation for outbound rosetta client request/responses to track slow or failing endpoints #390

Open
HassanAmed opened this issue Feb 15, 2023 · 1 comment · May be fixed by #395
Open
Labels
enhancement New feature or request

Comments

@HassanAmed
Copy link

Is your feature request related to a problem? Please describe.
Currently, there is no instrumentation support in rosetta-cli. Adding flag to enable instrumentation should start tracing outbound requests to measure their response time, error percentages, p99, p95, p50 etc
We can add an enable-request-instrumentation flag in config.json to enable or disable instrumentation.

Describe the solution you'd like
If we can integrate some instrumentation library such as open telemetry in rosetta-cli, we can instrument request/response of rosetta endpoints.

We would be able to see slow and error requests.

Describe alternatives you've considered
Problems with current performance tooling:

  1. check:perf
    It needs to be run as a separate process and measure results for /block and /account/balance endpoint.
    /account/balance is not using "address" value from blocks but is using hard-coded "address" string which is why all of requests fail due to address validation.
  2. --block-profile
    It is great to measure block pprof data but does not shows which requests failed or are slow.

Additional context
Adding instrumentation could potentially slow down the process which is why it is important to have enable/disable configuration added for it.

@HassanAmed HassanAmed added the enhancement New feature or request label Feb 15, 2023
@HassanAmed HassanAmed linked a pull request Apr 15, 2023 that will close this issue
@HassanAmed
Copy link
Author

Fixed in #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant