Add hooks to allow overriding Helper field in Syncer #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed by a Concordium fork of 'rosetta-cli' that understands account aliases. This is necessary for the 'rosetta-cli check:data' test to pass on a Concordium network.
bisgardo
commented
Jul 6, 2022
Comment on lines
+72
to
+76
| func WithExtraSyncerOpts(os ...syncer.Option) Option { | ||
| return func(s *StatefulSyncer) { | ||
| s.extraSyncerOpts = os | ||
| } | ||
| } |
There was a problem hiding this comment.
A more flexible solution would be to instead register a mapping function (similar to what is passed to WithCustomHelper below).
The usage of this from our fork would then be something like
statefulsyncer.WithCustomSyncerOpts(
func(opts ...syncer.Option) []syncer.Option {
return append(
opts,
syncer.WithCustomHelper(func(h syncer.Helper) syncer.Helper {
return newConcordiumHelper(h)
}))
},
),
Might be a little too much complexity...
bisgardo
added a commit
to Concordium/rosetta-sdk-go
that referenced
this pull request
Sep 10, 2022
…extra options The solution described in comment coinbase#423 (comment). It mostly demonstrates that it adds too much complexity for what it gains.
bisgardo
added a commit
to Concordium/rosetta-cli
that referenced
this pull request
Sep 10, 2022
…extra options The solution described in comment coinbase/mesh-sdk-go#423 (comment). It mostly demonstrates that it adds too much complexity for what it gains.
|
Is anyone ever going to take a look at this? @jingweicb @shrimalmadhur @GeekArthur |
@bisgardo sorry for making you waiting, will circle back later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #422.
Motivation
For
rosetta-cli check:datato do accounting correctly on the Concordium blockchain, it needs to rewrite account addresses into the same "normalized" alias.Solution
Add (stateful)syncer options for overriding
syncer.Options passed tosyncer.Newfrom outside thestatefulsyncer.New.Our internal fork of
rosetta-cliis able to utilize this in https://github.com/Concordium/rosetta-cli/pull/1/files.Open questions
There might be better ways to solve the underlying problem than patching block results, but I haven't been able to find one that works as reliably. So even if this is a bit brute-force'ish it's good enough for me.