From e2629682d3f207f88394620f09984bd169fbf72b Mon Sep 17 00:00:00 2001 From: Alec Chen <93971719+0xAlec@users.noreply.github.com> Date: Wed, 14 Aug 2024 14:36:56 -0700 Subject: [PATCH] fixes --- src/internal/svg/fundWallet.tsx | 6 +++--- src/wallet/components/WalletDropdownFundLink.test.tsx | 4 ++-- src/wallet/components/WalletDropdownFundLink.tsx | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/internal/svg/fundWallet.tsx b/src/internal/svg/fundWallet.tsx index a71f805203..ccca7ee7ce 100644 --- a/src/internal/svg/fundWallet.tsx +++ b/src/internal/svg/fundWallet.tsx @@ -4,9 +4,9 @@ export const FundWalletSvg = ( diff --git a/src/wallet/components/WalletDropdownFundLink.test.tsx b/src/wallet/components/WalletDropdownFundLink.test.tsx index 61a4a3d982..406e73e486 100644 --- a/src/wallet/components/WalletDropdownFundLink.test.tsx +++ b/src/wallet/components/WalletDropdownFundLink.test.tsx @@ -52,7 +52,7 @@ describe('WalletDropdownFundLink', () => { // Check if window.open was called with the correct arguments expect(mockOpen).toHaveBeenCalledWith( expect.stringContaining('http://keys.coinbase.com/fund'), - 'Coinbase Fund Wallet', + undefined, expect.stringContaining( 'width=297,height=371,resizable,scrollbars=yes,status=1,left=364,top=199', ), @@ -105,7 +105,7 @@ describe('WalletDropdownFundLink', () => { const expectedTop = Math.round((screenHeight - adjustedHeight) / 2); expect(mockOpen).toHaveBeenCalledWith( expect.stringContaining('http://keys.coinbase.com/fund'), - 'Coinbase Fund Wallet', + undefined, expect.stringContaining( `width=${expectedWidth},height=${adjustedHeight},resizable,scrollbars=yes,status=1,left=${expectedLeft},top=${expectedTop}`, ), diff --git a/src/wallet/components/WalletDropdownFundLink.tsx b/src/wallet/components/WalletDropdownFundLink.tsx index da7e3e0849..e860fae8a5 100644 --- a/src/wallet/components/WalletDropdownFundLink.tsx +++ b/src/wallet/components/WalletDropdownFundLink.tsx @@ -38,7 +38,7 @@ export function WalletDropdownFundLink({ const windowFeatures = popupFeatures || `width=${width},height=${height},resizable,scrollbars=yes,status=1,left=${left},top=${top}`; - window.open(fundingUrl, 'Coinbase Fund Wallet', windowFeatures); + window.open(fundingUrl, target, windowFeatures); }; const overrideClassName = cn(