From f162d4b71a2d80cf834b3546cc3a6b735660ea94 Mon Sep 17 00:00:00 2001
From: Alec Chen <93971719+0xAlec@users.noreply.github.com>
Date: Wed, 14 Aug 2024 11:03:57 -0700
Subject: [PATCH] `openIn=window` -> `popup`

---
 site/docs/pages/wallet/types.mdx                      | 4 ++--
 src/wallet/components/WalletDropdownFundLink.test.tsx | 4 ++--
 src/wallet/types.ts                                   | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/site/docs/pages/wallet/types.mdx b/site/docs/pages/wallet/types.mdx
index ef31d99f05..bc22cb9df1 100644
--- a/site/docs/pages/wallet/types.mdx
+++ b/site/docs/pages/wallet/types.mdx
@@ -90,10 +90,10 @@ export type WalletDropdownFundLinkReact = {
   href: string;
   icon?: ReactNode;
   rel?: string;
-  openIn?: 'window' | 'tab'; // Whether to open the funding flow in a tab or a window
+  openIn?: 'popup' | 'tab'; // Whether to open the funding flow in a tab or a popup window
   target?: string; // Where to open the target if `openIn` is set to tab
   text?: string; // Optional text override
-  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to window
+  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to `popup`
 };
 ```
 
diff --git a/src/wallet/components/WalletDropdownFundLink.test.tsx b/src/wallet/components/WalletDropdownFundLink.test.tsx
index 03309a4e52..868f04645c 100644
--- a/src/wallet/components/WalletDropdownFundLink.test.tsx
+++ b/src/wallet/components/WalletDropdownFundLink.test.tsx
@@ -44,7 +44,7 @@ describe('WalletDropdownFundLink', () => {
     // Mock window.screen
     vi.stubGlobal('screen', { width: 1024, height: 768 });
 
-    render(<WalletDropdownFundLink openIn="window" />);
+    render(<WalletDropdownFundLink openIn="popup" />);
 
     const linkElement = screen.getByText('Fund wallet');
     fireEvent.click(linkElement);
@@ -84,7 +84,7 @@ describe('WalletDropdownFundLink', () => {
 
       render(
         <WalletDropdownFundLink
-          openIn="window"
+          openIn="popup"
           popupSize={size as keyof typeof testCases}
         />,
       );
diff --git a/src/wallet/types.ts b/src/wallet/types.ts
index c9479e4cfd..ce9abf2d3f 100644
--- a/src/wallet/types.ts
+++ b/src/wallet/types.ts
@@ -104,10 +104,10 @@ export type WalletDropdownFundLinkReact = {
   href: string;
   icon?: ReactNode;
   rel?: string;
-  openIn?: 'window' | 'tab'; // Whether to open the funding flow in a tab or a window
+  openIn?: 'popup' | 'tab'; // Whether to open the funding flow in a tab or a popup window
   target?: string; // Where to open the target if `openIn` is set to tab
   text?: string; // Optional text override
-  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to window
+  popupSize?: 'sm' | 'md' | 'lg'; // Size of the popup window if `openIn` is set to `popup`
 };
 
 /**