You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This may be a personal preference thing but to me, Base is 8453... if I want to use a helper to detect if something "isBase", it should only return true if the chain is 8453.
The logic behind isBase is that we want something that helps us quickly to check a particular chain support. In particular for the CDP APIs, which are mostly bounded for now to Base or Base Sepolia.
I agree with you it can feel a bit confusing, and we specified the scope of the utility in the docs.
Happy to continue reflect on this in V1 if we see more adoption and confusion around this utility.
Describe the solution you'd like
This may be a personal preference thing but to me, Base is 8453... if I want to use a helper to detect if something "isBase", it should only return true if the chain is 8453.
Currently, isBase will return true for Base Sepolia as well.
Perhaps for backwards compatibility, there should be optional parameters passed like:
Describe alternatives you've considered.
it's simple enough for me to make my own "isBaseMainnet" function:
but I feel like someone could stumble over "isBase" returning true for sepolia.
The text was updated successfully, but these errors were encountered: