Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not go full width at 1440p #129

Open
Strykar opened this issue May 8, 2021 · 7 comments
Open

Does not go full width at 1440p #129

Strykar opened this issue May 8, 2021 · 7 comments
Labels
question Further information is requested

Comments

@Strykar
Copy link

Strykar commented May 8, 2021

At 2560x1440 resolution in a windowed (Alacritty) and full screen (Kitty) terminal, cointop does not extend fully to the right.
See https://i.imgur.com/B5U210U.png

@miguelmota
Copy link
Member

Hi @Strykar, would you expect all the columns to be evenly spaced out in this case?

@miguelmota miguelmota added the question Further information is requested label May 11, 2021
@Strykar
Copy link
Author

Strykar commented May 11, 2021

@miguelmota Hi, yes, auto adjusting the columns based on width would be nice, esp. at higher resolutions.

@lyricnz
Copy link
Collaborator

lyricnz commented Sep 28, 2021

Is it the chart you're interested in, or the table? (the chart is easy/trivial, the table code would be a lot more involved)

Chart width option - #189

Set max_chart_width = 0 in config.toml then it looks like this:
Screen Shot 2021-09-28 at 2 21 30 pm

@Strykar
Copy link
Author

Strykar commented Sep 28, 2021

Is it the chart you're interested in, or the table? (the chart is easy/trivial, the table code would be a lot more involved)

No, that appears like the current chart with just the graph and date columns spilling over to the right.

@lyricnz
Copy link
Collaborator

lyricnz commented Sep 28, 2021

I asked: Is it the chart you're interested in, or the table? (and I provided a solution for the chart).

It seems you're interested in the table too? What do you suggest - just adding padding to all the columns evenly until it fills the space? This may make it hard to read / line-up?

lyricnz added a commit that referenced this issue Sep 29, 2021
#129 Allow configurable max_chart_width (default 175, if 0 use full width)
@Strykar
Copy link
Author

Strykar commented Mar 23, 2022

I asked: Is it the chart you're interested in, or the table? (and I provided a solution for the chart).

It seems you're interested in the table too? What do you suggest - just adding padding to all the columns evenly until it fills the space? This may make it hard to read / line-up?

Both, chart and table.
Honestly I can't think of a better solution than padding, which may not be worth the effort as you point out.

@deathtrip
Copy link

I would like to add that it happens for me on 1080p also, so it's probably independent of resolution.
I also think padding is the best solution, as right now the columns seem squeezed together if the values are very large.
Some coin names are even cut off, which doesn't make sense when there's so much space left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants