From f2b3a34686e2f4817a0798ff1281e34bd181d9ac Mon Sep 17 00:00:00 2001
From: Dan Rose <dan@digilabs.io>
Date: Wed, 25 Mar 2020 17:57:49 -0500
Subject: [PATCH] Don't continue with testing if an extension crashes

---
 colcon_core/task/python/test/__init__.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/colcon_core/task/python/test/__init__.py b/colcon_core/task/python/test/__init__.py
index d61e529a..546242b7 100644
--- a/colcon_core/task/python/test/__init__.py
+++ b/colcon_core/task/python/test/__init__.py
@@ -27,7 +27,6 @@ def add_arguments(self, *, parser):  # noqa: D102
         add_python_testing_step_arguments(parser)
 
     async def test(self, *, additional_hooks=None):  # noqa: D102
-        pkg = self.context.pkg
         args = self.context.args
 
         logger.info(
@@ -59,8 +58,7 @@ async def test(self, *, additional_hooks=None):  # noqa: D102
                         'Exception in Python testing step extension '
                         "'{extension.STEP_TYPE}': {e}\n{exc}"
                         .format_map(locals()))
-                    # skip failing extension, continue with next one
-                    continue
+                    return 1
                 if matched:
                     break
             else: