Tray menu shows invalid entry on first launch and icons are hard to see

[enoryw]

Two issues running /usr/bin/udiskie -C --no-automount --smart-tray --appindicator seen here (I'm using --appindicator as I'm on Wayland and I'm guessing it's more appropriate but issues remain whether I use it or not):

• There is an empty entry at the bottom which is only shown when the menu is first shown. With --smart-tray, there is a very brief "Quit" shown and then immediately hidden like shown in the picture. Subsequent launches of the menu don't have this problem.

• Some icons like the checkbox next to "Enable notifications" and the arrow next to "Managed devices" appear to be hardcoded black, so it is impossible/hard to see unless the tray menu background is set to a bright color and the foreground/font color set to black. I prefer the tray menu to be black to match the rest of the theme and the icons to use the same color as the foreground/font color (white in my case). I am using waybar.

P.S. Unrelated question, but it would be nice if right-click on the tray icon does something different than left click for convenience. For example, left click can show all of the devices immediately (without being grouped under "Managed devices" and secondary (less frequently-used) settings like "Enable notifications", "Enable automounting", and "Quit" can be shown on right-click. Not sure if this is possible with --appindicator.

[coldfix]

Hey,

There is an empty entry at the bottom which is only shown when the menu is first shown. With --smart-tray, there is a very brief "Quit" shown and then immediately hidden like shown in the picture. Subsequent launches of the menu don't have this problem.

Sounds like it's the long standing issue of waybar being unable to adjust tray menu sizes correctly on first show, see #199 and also Alexays/Waybar#1149.

Some icons like the checkbox next to "Enable notifications" and the arrow next to "Managed devices" appear to be hardcoded black, so it is impossible/hard to see unless the tray menu background is set to a bright color and the foreground/font color set to black. I prefer the tray menu to be black to match the rest of the theme and the icons to use the same color as the foreground/font color (white in my case). I am using waybar.

That's my bad. I had to implement a workaround for waybar tray menus to show custom icons for checkboxes (see #215 Alexays/Waybar#1148) but didn't account for dark window themes. I guess a possible fix would be to add a light outline around the icon path of the icons udiskie-checkbox-checked.svg, udiskie-checkbox-unchecked.svg, udiskie-submenu.svg in udiskie/icons/. You can try running udiskie with --no-menu-checkbox-workaround (can also be configured in the config file). If you're running a recent version of waybar, it should display usable default icons.

P.S. Unrelated question, but it would be nice if right-click on the tray icon does something different than left click for convenience. For example, left click can show all of the devices immediately (without being grouped under "Managed devices" and secondary (less frequently-used) settings like "Enable notifications", "Enable automounting", and "Quit" can be shown on right-click. Not sure if this is possible with --appindicator.

I'm not sure that's possible. AppIndicator was a regrettable step back well in line with canonical's ongoing effort to dumb down the user experience :(